Skip to content

[Vanilla Fix] Fix the bug that infantry weapons with both LimboLaunch=yes and ammunition logic could not set ReloadTimer properly - #2478

Merged
DeathFishAtEase merged 16 commits into
Phobos-developers:developfrom
dh381-1:bugfix/UnlimboDecreaseAmmo
Oct 25, 2026
Merged

DeathFishAtEase merged 16 commits into
Phobos-developers:developfrom
dh381-1:bugfix/UnlimboDecreaseAmmo

Conversation

@dh381-1

@dh381-1 dh381-1 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

  • In vanilla, if an infantry attacks with a weapon that has both LimboLaunch=yes and Ammo configured, ReloadTimer cannot be set properly, causing the infantry to fail to consume the first round of ammunition after calling Unlimbo(). This bug has now been fixed.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/840/1

@DeathFishAtEase DeathFishAtEase added ❓Vanilla bug Vanilla game bugs that are requested to be fixed Needs testing ⚙️T1 T1 maintainer review is sufficient labels Oct 20, 2026
Comment thread src/Ext/Techno/Hooks.Firing.cpp Outdated
Comment thread src/Ext/Techno/Hooks.Firing.cpp Outdated
Comment thread src/Ext/Infantry/Hooks.Firing.cpp Outdated
@Coronia

Coronia commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Does this problem also exist for unit like Terror Drone's attack?

@DeathFishAtEase

DeathFishAtEase commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Does this problem also exist for unit like Terror Drone's attack?

❌️
See https://www.phoboscn.top/t/topic/840/3?u=noble_fish.

@DeathFishAtEase DeathFishAtEase changed the title [Vanilla Fix] Fixed the bug that weapons with LimboLaunch=yes and ammunition logic could not set ReloadTimer properly [Vanilla Fix] Fix the bug that infantry weapons with both LimboLaunch=yes and ammunition logic could not set ReloadTimer properly Oct 21, 2026
@DeathFishAtEase DeathFishAtEase added Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. and removed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. labels Oct 21, 2026
@DeathFishAtEase DeathFishAtEase added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Oct 24, 2026
@DeathFishAtEase
DeathFishAtEase merged commit cfc3257 into Phobos-developers:develop Oct 25, 2026
6 of 7 checks passed
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested ❓Vanilla bug Vanilla game bugs that are requested to be fixed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants