Repository navigation
[Vanilla Fix] IsSimpleDeployer Deploy Fix when using Deploy Script (9,0) - #2461
Open
deathreaperz wants to merge 4 commits into
Open
deathreaperz wants to merge 4 commits into
deathreaperz wants to merge 4 commits into
Conversation
NetsuNegi
added
❓Vanilla bug
Contributor
|
Needs docs. |
Author
Done |
NetsuNegi
reviewed
Oct 9, 2026
| } | ||
| else | ||
| { | ||
| R->Stack<BYTE>(0x13, 0); |
Contributor
There was a problem hiding this comment.
Suggested change
| R->Stack<BYTE>(0x13, 0); | |
| R->Stack<BYTE>(STACK_OFFSET(0x24, -0x11), 0); |
Contributor
There was a problem hiding this comment.
I guess it's same as 0x6ED667, right?
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Collaborator
|
Could you attach a map where, as soon as it starts, you can see two units switching back and forth because of one 9,0? I have encountered similar things before, and I have also encountered a specific need for multiple deploy commands, so I need to reproduce this issue and do some testing, but here I cannot reproduce the original issue directly using the following configuration. [SCRIPT - A] ; Single action, for pure testing use
0=9,0
[SCRIPT - B] ; Multiple actions, simulating regular actions
0=3,88
1=9,0
2=49,0
[TNKD]
IsSimpleDeployer=true
Convert.Deploy=DTRUCK
[DTRUCK]
IsSimpleDeployer=true
Convert.Deploy=TNKD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
Skip Changelog).Skip Changelog,Skip Docs).Skip Docs).Skip Changelog,Skip Docs,Skip Credits).Description
In vanilla, IsSimpleDeployer units (especially Siege Chopper) cannot deploy or bugged deploy (deploy-then-undeploy loop) when using Deploy Script (9,0). This patch fixes it.
Before
Note: The land and air IsSimpleDeployer sometimes bugged during deploy. This preview only shows the air bug.
After
Note: The land IsSimpleDeployer was also tested without DeployingAnim and worked.