Skip to content

Fix runtime_artifacts walk performance - #3219

Open
mehrdad2m wants to merge 3 commits into
mainfrom
fix-backline-perf
Open

mehrdad2m wants to merge 3 commits into
mainfrom
fix-backline-perf

Conversation

@mehrdad2m

@mehrdad2m mehrdad2m commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Context:
Currently there is a performance degradation issue with catalyst.runtime_artifacts where it walks the entire IR operations looking for runtime_artifacts which is unnecessary.

Description of the Change:
It now visits module operations only, instead of every operation in the program.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-129402]

@mehrdad2m

Copy link
Copy Markdown
Contributor Author

!benchmark

@dime10

dime10 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

What I don't understand is how a single walk could produce a meaningful degradation, since we do do walks quite often (although I agree recursive walks should be avoided if unnecessary) 🤔

@mehrdad2m

Copy link
Copy Markdown
Contributor Author

!benchmark

1 similar comment
@jzaia18

jzaia18 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

!benchmark

@ringo-but-quantum

Copy link
Copy Markdown
Collaborator

Hi @jzaia18, thanks for your benchmark request! We have received the request to benchmark this PR. We will start running the benchmarks shortly and will add a new comment with the results once they are ready.

See this README section for more information on how the benchmarks are triggered and run.

Reports to expect:

  • A report analyzing the performance of 'lightning.qubit'.
  • A report analyzing the performance of 'null.qubit'.

You can track the progress of the benchmarks here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants