Store message redirects - #5683
Merged
Merged
Conversation
rbev
requested changes
Aug 3, 2026
Contributor
There was a problem hiding this comment.
We should be doing RavenDB/API refactorings in standalone PRs so that it's easier on anyone doing a SC release.
johnsimons
force-pushed
the
john/message_redirects
branch
from
August 3, 2026 05:15
cbf2369 to
e75d22b
Compare
johnsimons
force-pushed
the
john/message_redirects
branch
from
August 3, 2026 05:58
e75d22b to
3d0e3aa
Compare
johnsimons
force-pushed
the
john/message_redirects
branch
from
August 3, 2026 06:51
3d0e3aa to
d6a72a1
Compare
rbev
approved these changes
Aug 3, 2026
Adds a MessageRedirects table for SQL Server and PostgreSQL, keyed on FromPhysicalAddress since MessageRedirectId is a deterministic hash of it. IMessageRedirectsDataStore now exposes AddRedirect, UpdateRedirect and RemoveRedirect instead of Save(collection), because every caller changes one redirect at a time. Reads still return all of them, which the API needs for its validation. The Raven specific parts move into the Raven project: the stored document type, its tick based timestamp and the change vector handling. What is left in the shared model is the redirect itself, with the lookups as extension methods. IRetryBatchesManager.GetOrCreateMessageRedirectsCollection duplicated the store's read, so it is removed and RetryProcessor takes IMessageRedirectsDataStore directly. The redirect GET endpoints compute their ETag from the payload.
johnsimons
force-pushed
the
john/message_redirects
branch
from
August 3, 2026 07:30
d6a72a1 to
794cfe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message redirect persistence for the SQL Server and PostgreSQL persisters.
Changes
MessageRedirectstable keyed onFromPhysicalAddress, sinceMessageRedirectIdis a hash of it, with migrations for both providers.IMessageRedirectsDataStoreexposesAddRedirect,UpdateRedirectandRemoveRedirectratherSave(collection), since every caller changes a single redirect.GetRedirectsstill all of them for the API's duplicate and dependents validation.IRetryBatchesManager.GetOrCreateMessageRedirectsCollectionduplicated the store's read, so it removed andRetryProcessortakesIMessageRedirectsDataStore.Behaviour changes