Repository navigation
fix(mcp): keep stdout for JSON-RPC only - #126
Merged
Merged
Conversation
`neuromesh mcp` also starts the local dashboard in the same process, and the dashboard printed its banner with println!, so the first lines a strict MCP client read on stdout were box-drawing text, not JSON. Reported by the upstream author on v1.0.0; reproduced with a new test that spawns the real binary and parses every stdout line (fails on the old code with the banner line, passes now). - banner -> stderr - browser child process never inherits stdout; NEUROMESH_NO_BROWSER turns the first-run browser open off - first-run marker is per project (pending change from the dashboard work, committed here since it touches the same function) - planning: Yoosef's findings handoff + roadmap for concept queries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard banner went to stdout inside
neuromesh mcp, breaking strict MCP stdio clients (reported on v1.0.0). New testcrates/neuromesh-cli/tests/mcp_stdout_clean.rsspawns the real binary and requires every stdout line to be JSON: fails on the old code (banner line), passes now.Also: browser child never inherits stdout;
NEUROMESH_NO_BROWSER; per-project first-run marker; roadmapdocs/planning/11-roadmap-2026-09-30-concept-queries.fa.md.🤖 Generated with Claude Code