Repository navigation
Implement recoverable account deletion and lifecycle emails - #40
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a recoverable account-deletion lifecycle with a 30-day window, explicit recovery, ordered lifecycle emails, and permanent cleanup. User responses also expose connected providers so the client can identify linked Google accounts.
Updated against current
development, including merged support PR #41. The PR diff contains only account-deletion changes. The stale user-column assertion that failed the previous CI run now includes both deletion timestamps.Validation: 144 focused PostgreSQL-backed server tests and 26 client deletion/recovery tests passed. The full server run passed 457 tests, with only the ignored local
.envkey-alignment check failing. After adding missing defaults without changing effective settings, all five environment/model checks passed. Two external provider smoke tests were excluded. Ruff, formatting, Mypy (186 files), and the OpenAPI snapshot freshness check passed. Live provider delivery and production deployment were not rerun.Deployment: run
alembic upgrade headthrougha8b9c0d1e234, then deploy the server before releasing the client. The former disable-onlyDELETE /users/meroute is replaced. Existing PowerSync tokens expire naturally. Automated backups remain unimplemented, with a configurable retention notice and a planned 30-day limit for future backups.Companion client #73 and docs #85 are already merged. The combined API snapshot is included in merged docs #86.
Related: FR-1_6, UC-1_6. This does not close the requirement: the app's exact dated preview and live deployment acceptance remain documented gaps.