Skip to content

Expose individual EPUB pages in reading activity coverage - #19

Merged
Eoic merged 2 commits into
developmentfrom
fix/epub-rendered-page-coverage
Nov 2, 2026
Merged

Eoic merged 2 commits into
developmentfrom
fix/epub-rendered-page-coverage

Conversation

@Eoic

@Eoic Eoic commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

EPUB activity previously described a chapter viewport, so the client could not count the actual pages shown without estimating from publisher metadata. Emit a separate stable coverage identity for each rendered page, including both columns of a spread. Identity uses the stable page start rather than its provisional end, so background pagination cannot create a second identity for the same page. Scrolling retains that identity while clipping visible content offsets, and navigation back to a page reuses its identity. Page-scoped coverage omits chapterCount, allowing hosts to distinguish it from chapter-calibrated estimates.

Fixes #18. Contributes to FR-5_1 (PapyrusReader/docs#34). Companion client task: PapyrusReader/client#119.

Validation: all 235 reader tests pass, including prefetch identity stability, single/double-column coverage and forward/back navigation. tools/papyrus check reader passes formatting, generated-worker drift validation, reader analysis and example analysis. All 29 focused client tests pass with the updated local reader and, separately, with the client's unchanged Git-pinned reader. Native-device and live browser acceptance were not run.

No version or client dependency pin change is included.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T19:59:53.815389Z 6593205 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6593205b13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/src/engine/epub/epub_viewport.dart Resolved
@Eoic
Eoic merged commit fa667ae into development Nov 2, 2026
4 checks passed
@Eoic
Eoic deleted the fix/epub-rendered-page-coverage branch November 2, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose rendered EPUB pages in reading coverage

2 participants