Repository navigation
Use readiness checks and avoid duplicate reader CI runs - #12
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Eoic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11. Supports NFR-9_1.
The browser smoke helper unconditionally waited 60 animation frames at dozens of checkpoints. Wait for expected content, selected settings, dismissed panels/menus, library navigation, and actual scroll movement before stable semantic content and geometry. Waits are bounded at five seconds and account for Flutter repeating the accessible name while a tooltip is hovered. Keep one short pause for the intentional PDF wheel debounce.
All existing browser scenarios remain, including worker cleanup, malformed documents, selection, keyboard navigation, PDF modes, and resume behavior. Restrict push CI to development/master, retain PR checks, and cancel superseded runs. This avoids executing the entire test/desktop matrix twice for feature-branch PR updates. No reader API or production behavior changes.
Validation: formatting, worker-generation drift checks, and package/example analysis passed. All 213 package tests and 2 example tests passed, and the example web build passed. The stricter readiness smoke passed twice, with the timed repeat taking 31.93s versus the original 99.31s. Actionlint passed. The first CI run of the earlier wait cleanup took 32s versus a previously observed 112s. Equivalent hosted CI and aggregate runner-time savings remain unmeasured.