Skip to content

Fix EPUB boundary page turns and keep page counts visible - #10

Merged
Eoic merged 2 commits into
developmentfrom
fix/seamless-epub-page-turns
Oct 28, 2026
Merged

Eoic merged 2 commits into
developmentfrom
fix/seamless-epub-page-turns

Conversation

@Eoic

@Eoic Eoic commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Crossing an EPUB spine boundary previously waited for the entire destination layout and replaced the page without animation. This change prepares pages incrementally, shares in-flight prefetch work with navigation, and animates forward/backward boundary turns while preserving the committed reading position until the destination is visible.

The bottom bar consistently shows Chapter X of Y · Page X of Y. An explicit ≈ marks estimated totals until a separate yielding counter finishes. Counting does not retain the remaining pages or advance the reading cursor. Geometry changes and disposal cancel both layout and counting work. Reduced motion, queued turns, selection, reflow, and content-offset restoration remain covered.

Closes #9.

Requirements: FR-3_1 and FR-3_2, limited to EPUB navigation and pagination.

Validation:

  • 213 reader tests passed, including long single-spine content, shared prefetch, boundary animations, rapid turns, interrupted forward/backward animations, page-count updates, and cancellation.
  • Reader analysis, formatting, diff checks, and generated-worker drift check passed.
  • Example analysis, 2 example tests, and web build passed.
  • 22 focused client reader tests and tools/papyrus check client passed with the existing local reader override.
  • Browser smoke covered page turns and keyboard focus. Final focused desktop/mobile browser checks verified exact totals across turns, chapter boundaries, and resizing, with no page errors.

Cold jumps into unmeasured content still require yielding layout work. Continuous scrolling still collects a full layout for its scroll extent. Real-device performance has not been profiled. Client release pins and workspace submodule pointers are unchanged.

Client integration: merged client PR PapyrusReader/client#101 adopted the initial revision. Follow-up PapyrusReader/client#103 pins the interruption review fix at e6c59a7eb238b2088b0b92b25f36b617d63181c1. Merge this reader PR before the follow-up client PR.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 22:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:33:20.616714Z 865e94a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 865e94adff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/src/engine/epub/epub_viewport.dart Resolved
@Eoic
Eoic merged commit 1c88906 into development Oct 28, 2026
8 checks passed
@Eoic
Eoic deleted the fix/seamless-epub-page-turns branch October 28, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make EPUB page turns seamless across spine boundaries

2 participants