Skip to content

Update About settings and add in-app support - #78

Merged
Eoic merged 4 commits into
developmentfrom
feat/about-and-support
Oct 23, 2026
Merged

Eoic merged 4 commits into
developmentfrom
feat/about-and-support

Conversation

@Eoic

@Eoic Eoic commented Oct 23, 2026

Copy link
Copy Markdown
Member

About settings now show the installed app version, link to that release's changelog, open the client repository, and provide an in-app support form with image/video attachments. Licenses and Support use the shared page header, and the license browser disables animations.

Issue and requirements

Requested directly by the maintainer. Related design requirements: NFR-5_1 and NFR-3_4. Support submission requires PapyrusReader/server#41.

Summary

  • Read runtime version/build metadata and put What's new after Support, with external-link indicators for browser destinations.
  • Replace Flutter's default license page with a responsive, static license browser using the app's typography and dividers.
  • Submit bug reports or feature requests directly to the configured server. Attach up to five images/videos, retain form contents after failure, and show a compact confirmation with the created issue link.
  • Keep GitHub credentials and routing configuration on the server. Accept validated HTTPS GitHub issue links from configured support repositories.

Testing

33 focused tests passed across About settings, licenses, support form, attachments, API handling, and confirmation. tools/papyrus check client, the web build, and git diff --check passed. Dark/light/e-ink and narrow layouts with larger text are covered. The local reader override points to the exact pinned reader revision and is excluded from the commit.

UI evidence

The support confirmation was visually checked in a local render with the actual sidebar and shared page header. It uses the form's width, standard text sizes, and a compact settings-style issue row. No screenshot is attached. Native device acceptance remains unrun.

Compatibility and migration

No persistence migration. Requires the companion server endpoint for submissions. New runtime dependency: package_info_plus; url_launcher is now an explicit dependency. Builds retain the current application version.

Notes

Feedback and attachments are public, which the form discloses before submission. Errors retain the draft and display Submission failed. No automatic submission retries.

Checklist

  • Branch, commits, and PR title follow repository conventions.
  • Change is limited to the agreed scope.
  • Relevant behavioral tests are included.
  • Formatting, analysis, focused tests, and web compilation pass.
  • Documentation and UI verification details are included.
  • No credentials, private fixtures, or local dependency overrides are included.
  • Branch is based on current development.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T16:17:19.272114Z a9b8adb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9b8adb6b3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/lib/pages/support_page.dart Resolved
@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

@Eoic
Eoic merged commit 05b0752 into development Oct 23, 2026
5 checks passed
@Eoic
Eoic deleted the feat/about-and-support branch October 23, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants