fix(SocFrameworkProofPointTap): full XDM mapping + rename modeling rule off the marketplace id - #1158
Closed
scottbrumley wants to merge 1 commit into
Closed
scottbrumley wants to merge 1 commit into
scottbrumley wants to merge 1 commit into
Conversation
…le off the marketplace id The shipped modeling rule mapped a single field. This replaces it with a full XDM mapping and fixes three install-blocking defects found by single-variable upload tests. Modeling rule - Rename: id ProofpointTAP_modeling_rule -> SOCFW_ProofpointTAP_v2_ModelingRule, name -> "SOC Proofpoint TAP v2 Modeling Rule", directory to match. The old id was byte-identical to the marketplace ProofpointTAP legacy rule id, so the two packs competed for one registration. - Full mapping: recipients/cc as JSON array strings rather than scalars, attachments from messageParts, threat detail from threatsInfoMap rather than the top-level threatID/threatURL columns, sender IP dual-stack, delivery timestamp, session_context_id, target url. Three defects that fail pack install with 101704 while the Data Model Rules editor accepts them -- the install validator and the editor do not agree: - json_extract_scalar_array() is rejected; use arraymap(json_extract_array()). - xdm.email.attachment.* is scalar; assigning an array fails. Wrap in arraystring() as the marketplace rule does. - xdm.email.from_name is not an XDM field: zero occurrences across all shipping content. Schema - messageTime/clickTime must be datetime, not string; messageParts and threatsInfoMap string, not json. Matches the marketplace schema. Added toAddresses, which the rule reads and the schema never declared. Release notes - ReleaseNotes/1.3.2.md -> 1_3_2.md; the SDK expects X_Y_Z.md. Known open, not addressed here: xdm.alert.category is null pending an enumeration of real classification values; source IP uses senderIP where the prior rule used clickIP; alert status maps active to PENDING where the prior rule used IN_REVIEW.
Contributor
Author
|
Superseded — replacing with the XSIAM AI-generated modeling rule verbatim plus the schema type fix. The XQL rewrites in this PR were unnecessary; the install failures were caused by the schema, not the rule body. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(SocFrameworkProofPointTap): full XDM mapping + rename modeling rule off the marketplace id
The shipped modeling rule mapped a single field. This replaces it with a full
XDM mapping and fixes three install-blocking defects found by single-variable
upload tests.
Modeling rule
name -> "SOC Proofpoint TAP v2 Modeling Rule", directory to match. The old id
was byte-identical to the marketplace ProofpointTAP legacy rule id, so the two
packs competed for one registration.
attachments from messageParts, threat detail from threatsInfoMap rather than
the top-level threatID/threatURL columns, sender IP dual-stack, delivery
timestamp, session_context_id, target url.
Three defects that fail pack install with 101704 while the Data Model Rules
editor accepts them -- the install validator and the editor do not agree:
arraystring() as the marketplace rule does.
shipping content.
Schema
threatsInfoMap string, not json. Matches the marketplace schema. Added
toAddresses, which the rule reads and the schema never declared.
Release notes
Known open, not addressed here: xdm.alert.category is null pending an
enumeration of real classification values; source IP uses senderIP where the
prior rule used clickIP; alert status maps active to PENDING where the prior
rule used IN_REVIEW.