Add Hem and HashedPhoneNumber identifiers - #47
Open
mosherBT wants to merge 2 commits into
Open
Conversation
Mirrors the .hem helper added to the iOS SDK, so a caller holding a SHA256 of an Email can pass it directly instead of building a prefixed Raw string. The value is normalized but never hashed again, and is dropped unless it is a SHA-256 digest, which keeps a plaintext Email off the wire. Raw is left untouched.
| val ids = listOf( | ||
| OptableIdentifier.Email("john.doe+test@example.com"), | ||
| OptableIdentifier.PhoneNumber("+1(555)1234567"), | ||
| // Already hashed? Pass it directly, it will not be hashed again: |
There was a problem hiding this comment.
nit: what about HashedPhoneNumbers, shouldn't it be here too?
zuolongwu-optable
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .hem helper, so a caller holding a SHA256 of an Email can pass it directly instead of building a prefixed Raw string.
The value is normalized but never hashed again, and is dropped unless it is a SHA-256 digest, which keeps a plaintext Email off the wire. Raw is left untouched.
Why
HEM support + Hashed phone number support
What Changed
How to Test
./gradlew testpassesNotes