Conversation
The 2-arg calls forward to the new 3-arg form with panel.delta, so a live flap deflection delta can drive POLAR_MATRICES interp(alpha, delta) while POLAR_VECTORS panels stay delta-insensitive. No duplicated dispatch bodies. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Resolves the Documentation build's missing_docs termination: copy_sections carried a docstring but was not listed in any @docs block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1-Bart-1
commented
Aug 1, 2026
1-Bart-1
commented
Aug 1, 2026
1-Bart-1
commented
Aug 1, 2026
1-Bart-1
commented
Aug 1, 2026
1-Bart-1
commented
Aug 1, 2026
1-Bart-1
commented
Aug 1, 2026
1-Bart-1
commented
Aug 1, 2026
After "Fix slicing" (f2e8296) the leading-edge march reaches the pointed tip, so a station placed exactly on the tip (wingtip_distance=0.0) collapses to LE == TE. A zero-chord panel divides by zero and poisons the whole solve with NaN, which surfaced as widespread CI failures in the results/solver tests once the geometry cache was regenerated. Inset the tip stations by default: obj_to_yaml now defaults wingtip_distance=0.05, and the ram-air test geometry passes it explicitly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.