Repository navigation
fix(log): the stream keeps rows that arrive while paused and shows them on resume - #166
Merged
Merged
Conversation
…em on resume Log › Pause held the Events view but the Stream view dropped every row that arrived while paused. The stream now holds them out of the frozen list and adds them on Resume, within the list's existing row cap (the oldest fall off as they do live). Clear while paused also drops what was held. Closes #161
mottihoresh
added a commit
that referenced
this pull request
Oct 18, 2026
…s, paused log keeps rows, can state reads ok (#167) The four parked items kept from the fix track (#135), prioritized 2026-10-18. Item PRs squash-merged into `fix/parked`: - #163 — a healthy CAN state reads "OK" instead of "error-active". - #164 — Connection › Connected nodes says "N new board(s) on the bus — add it/them from the Cockpit." when boards are on the bus but none is in your cockpit, instead of "No nodes reported". - #165 — Start with no Gateway (Bridge, or Replay driving the board) starts and waits for the board with the waiting reason shown, instead of being silently refused; delivery begins when the Gateway connects. - #166 — Log › Stream holds rows that arrive while paused and shows them on Resume (within the row cap), like Events. Closes #159 Closes #160 Closes #161 Closes #162 BEGIN_COMMIT_OVERRIDE fix(nodes): healthy CAN state reads "OK" instead of error-active fix(nodes): connected nodes points to new boards on the bus instead of saying none are reported fix(dcs): start with no gateway starts and waits for the board instead of being refused fix(log): the stream keeps rows that arrive while paused and shows them on resume END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Log › Pause held the Events view (rows recorded, shown on Resume), but the Stream view dropped every
log:batchthat arrived while paused, so that data was lost.Now the stream holds those rows while paused and shows them on Resume, within its existing 1000-row cap (the oldest fall off, as they do live). The paused list stays frozen in the meantime.
Changes
src/renderer/src/dcs/store.tslogBatchno longer returns early while paused. It numbers the rows as before and puts them in a newprivate_heldlist (newest first, capped atMAX_LOG) instead oflog.private_heldon top oflogwhen the pause turns off (Resume), capped atMAX_LOG.clearLogemptiesprivate_heldtoo.src/renderer/src/events/store.ts(logPaused/togglePause, unchanged). Only its header comment was updated to say the stream also reads it on Resume.Log.tsxis unchanged: no layout or styling change.Tests
src/renderer/test/t23-log-stream.test.tsx:All three fail on the old code.
Closes #161