Repository navigation
fix(nodes): connected nodes points to new boards on the bus instead of saying none are reported - #164
Merged
Merged
Conversation
…f saying none are reported With no board of your cockpit to count, Connection › Connected nodes said "No nodes reported. Power on a PanelGroup." even while a board not added yet was on the bus and reporting. Main now carries the new-board count in NodesSummary (newCount, the Overview notice's count, the same isReportableNew rule as the Cockpit's "New on the bus") and builds the card's line (empty): "1 new board on the bus — add it from the Cockpit." / "2 new boards on the bus — add them from the Cockpit.", else the old line. The renderer only shows it in the existing hint. Closes #160
mottihoresh
added a commit
that referenced
this pull request
Oct 18, 2026
…s, paused log keeps rows, can state reads ok (#167) The four parked items kept from the fix track (#135), prioritized 2026-10-18. Item PRs squash-merged into `fix/parked`: - #163 — a healthy CAN state reads "OK" instead of "error-active". - #164 — Connection › Connected nodes says "N new board(s) on the bus — add it/them from the Cockpit." when boards are on the bus but none is in your cockpit, instead of "No nodes reported". - #165 — Start with no Gateway (Bridge, or Replay driving the board) starts and waits for the board with the waiting reason shown, instead of being silently refused; delivery begins when the Gateway connects. - #166 — Log › Stream holds rows that arrive while paused and shows them on Resume (within the row cap), like Events. Closes #159 Closes #160 Closes #161 Closes #162 BEGIN_COMMIT_OVERRIDE fix(nodes): healthy CAN state reads "OK" instead of error-active fix(nodes): connected nodes points to new boards on the bus instead of saying none are reported fix(dcs): start with no gateway starts and waits for the board instead of being refused fix(log): the stream keeps rows that arrive while paused and shows them on resume END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Connection › Connected nodes said "No nodes reported. Power on a PanelGroup." while a board not yet added to the cockpit was on the bus and reporting. With no board of your cockpit to count, the card now says where the new ones are:
When cockpit boards exist the card is unchanged.
How
src/shared/nodes/ipc.ts—NodesSummarygainsnewCountandempty(the card's line whenknownis 0);NO_NODESconstant used byCOCKPIT_IDLEand main.src/main/nodes/cockpit-snapshot/summaries.ts—nodesSummarytakesnewCountfromnewDevices(views, live)(the Overview notice's count; the sameisReportableNewrule as the Cockpit's "New on the bus · N"), andemptyLinebuilds the sentence in main, like the card'sfooter.src/renderer/src/nodes/NodesCard.tsx— the existinghintshowssum.emptyinstead of the hard-coded text. No layout or styling change.Tests changed on purpose
src/main/nodes/cockpit-snapshot/connection-summary.test.ts— newnodesSummary with no board of your cockpit (#160): 1 / 2 new boards → count + wording; empty bus and a board still identifying → "No nodes reported…".src/renderer/test/t5-connection-nodes-card.test.tsx— new case viaemitScenario: empty bus → old line; 1 and 2 new boards → new lines; board added → normal card.All three new tests fail on the old code.
npm run lint,lint:deps,typecheck,npm test(1464) pass.Closes #160