test(spp_gis): assert the geofence GeoJSON core properties as a subset, not an exact set (#443)

spp_gis/README.rst

@@ -140,6 +140,16 @@ External Python libraries: ``shapely``, ``pyproj``, ``geojson``
 Changelog
 =========
 
+19.0.2.1.1
+~~~~~~~~~~
+
+- test(gis): the geofence GeoJSON properties test asserts the core keys
+  are present and no longer asserts that the incident keys are absent.
+  ``spp_api_v2_gis`` legitimately adds ``incident_id``/``incident_name``
+  to the same properties (and asserts their presence in its own tests),
+  so the absence check failed on every database carrying both modules.
+  No behaviour change (#443)
+
 19.0.2.1.0
 ~~~~~~~~~~
 

spp_gis/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "OpenSPP GIS",
     "category": "OpenSPP/Core",
-    "version": "19.0.2.1.0",
+    "version": "19.0.2.1.1",
     "sequence": 1,
     "author": "OpenSPP.org",
     "website": "https://github.com/OpenSPP/OpenSPP2",

spp_gis/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.2.1.1
+
+- test(gis): the geofence GeoJSON properties test asserts the core keys are present and no longer asserts that the incident keys are absent. `spp_api_v2_gis` legitimately adds `incident_id`/`incident_name` to the same properties (and asserts their presence in its own tests), so the absence check failed on every database carrying both modules. No behaviour change (#443)
+
 ### 19.0.2.1.0
 
 - feat: spatial operators support MultiPolygon and GeometryCollection, including distance buffering (re-land from #76).

spp_gis/static/description/index.html

@@ -518,6 +518,17 @@ <h2><a class="toc-backref" href="#toc-entry-1">Changelog</a></h2>
 </div>
 </div>
 <div class="section" id="section-1">
+<h1>19.0.2.1.1</h1>
+<ul class="simple">
+<li>test(gis): the geofence GeoJSON properties test asserts the core keys
+are present and no longer asserts that the incident keys are absent.
+<tt class="docutils literal">spp_api_v2_gis</tt> legitimately adds <tt class="docutils literal">incident_id</tt>/<tt class="docutils literal">incident_name</tt>
+to the same properties (and asserts their presence in its own tests),
+so the absence check failed on every database carrying both modules.
+No behaviour change (#443)</li>
+</ul>
+</div>
+<div class="section" id="section-2">
 <h1>19.0.2.1.0</h1>
 <ul class="simple">
 <li>feat: spatial operators support MultiPolygon and GeometryCollection,
@@ -532,7 +543,7 @@ <h1>19.0.2.1.0</h1>
 onto <tt class="docutils literal">spp.gis.geofence.tag</tt> records when upgrading from 19.0.2.0.x.</li>
 </ul>
 </div>
-<div class="section" id="section-2">
+<div class="section" id="section-3">
 <h1>19.0.2.0.0</h1>
 <ul class="simple">
 <li>Initial migration to OpenSPP2</li>

spp_gis/tests/test_geofence.py

@@ -224,10 +224,8 @@ def test_to_geojson_properties_structure(self):
         self.assertIn("created_from", props)
         self.assertIn("created_by", props)
         self.assertIn("create_date", props)
-
-        # Should NOT have incident fields in core
-        self.assertNotIn("incident_id", props)
-        self.assertNotIn("incident_name", props)
+        # Downstream modules may extend the properties (spp_api_v2_gis adds the
+        # incident fields), so the core contract is a subset, not an exact set.
 
     def test_to_geojson_collection(self):
         """Test converting multiple geofences to GeoJSON FeatureCollection."""