Skip to content

spp_api_v2: GET /Group?type= is documented and accepted but never applied #565

Description

@gonzalesedwin1123

Problem

GET /Group accepts a type query parameter (household/family/organization/other), documented in the router
docstring and passed into the search params (spp_api_v2/routers/group.py, ~187), but
SearchService.search_groups() never reads it. ?type=household returns every group.

PR #555 (#554 item H) made the other search filters fail closed; this one was left out because fixing it means
implementing the filter.

Proposal

Implement the filter (map to the group-type field/vocabulary; unknown type → empty result, malformed → 400, like the
other filters), or remove the parameter from the endpoint and docs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions