Skip to content

docs(incott): record the Zero 29 shell colour byte - #268

Open
finnwasabi wants to merge 1 commit into
OpenMouse-Project:mainfrom
finnwasabi:docs/incott-zero29-colour-byte
Open

finnwasabi wants to merge 1 commit into
OpenMouse-Project:mainfrom
finnwasabi:docs/incott-zero29-colour-byte

Conversation

@finnwasabi

@finnwasabi finnwasabi commented Oct 30, 2026 •

Copy link
Copy Markdown

Docs only. Records a lead on the undecoded identity bytes 7-8: the vendor's readDps() reads a shell colour for the Zero 29 (model code 0x06) and for no other model.

What the vendor code does

From the port in oexi/incott-driver-desktop (src/protocol/device.js, MIT; its tests diff every report against the vendor's original JavaScript):

if (r[2] === 6) {                     // model code 0x06, Zero 29
  const i1 = this.iswireless ? 6 : 5;
  this.isPink = r[i1] === 2;
}

r[n] is frame[n+1], so the flag is frame byte 7 behind the receiver and byte 6 on the cable, and 0x02 selects the pink product render and button diagrams.

Evidence and limits

  • Source reading only. Not read on a Zero 29, and incottDecodeIdentity is unchanged.
  • For contrast, a white G23 Pro reads 00 in both positions (09 8f 01 02 00 f1 00 00 00 cable, 09 8f 01 02 02 f0 f1 00 02 dongle; reports in test(incott): verify model code 0x02 on an original G23 Pro #261), consistent with the vendor reading no colour for other models.

Changes

  • docs/incott-testing.md: a "Shell colour: Zero 29 only" subsection under model identification, and a pointer to it from the bytes 7-8 item in "Unresolved unknowns".

Related: #261, #267.

Note

Document Zero 29 shell colour byte in incott testing notes

Adds documentation to incott-testing.md on the vendor's model-specific shell colour check for the Zero 29, including wireless and wired byte offsets and the pink-shell value. Notes that this behaviour is unverified on a Zero 29 and not implemented in incottDecodeIdentity. Also records white G23 Pro example replies.

Macroscope summarized 4401637.

The vendor's readDps() reads a pink flag for model code 0x06 only: frame byte 7 behind the receiver, byte 6 on the cable, 0x02 = pink. Transcribed from the oexi/incott-driver-desktop port (MIT). Not read on a Zero 29 and not decoded.
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1fd3f30 and 4401637.

Files selected for processing: 1
  • docs/incott-testing.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added type: documentation PR title category: documentation area: documentation Documentation labels Oct 30, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 30, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 4401637

Macroscope's review found this PR approvable — Records the Zero 29 shell-colour byte mapping and clearly states its verification limits. The change is documentation-only and does not alter driver behavior.

Notes:

  • Your repo's Minimum Blocking Severity is Off, so correctness findings do not automatically block approval.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: documentation Documentation type: documentation PR title category: documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant