Repository navigation
docs(incott): record the Zero 29 shell colour byte - #268
Open
finnwasabi wants to merge 1 commit into
Open
finnwasabi wants to merge 1 commit into
finnwasabi wants to merge 1 commit into
Conversation
The vendor's readDps() reads a pink flag for model code 0x06 only: frame byte 7 behind the receiver, byte 6 on the cable, 0x02 = pink. Transcribed from the oexi/incott-driver-desktop port (MIT). Not read on a Zero 29 and not decoded.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Records the Zero 29 shell-colour byte mapping and clearly states its verification limits. The change is documentation-only and does not alter driver behavior. Notes:
You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only. Records a lead on the undecoded identity bytes 7-8: the vendor's
readDps()reads a shell colour for the Zero 29 (model code0x06) and for no other model.What the vendor code does
From the port in oexi/incott-driver-desktop (
src/protocol/device.js, MIT; its tests diff every report against the vendor's original JavaScript):r[n]isframe[n+1], so the flag is frame byte 7 behind the receiver and byte 6 on the cable, and0x02selects the pink product render and button diagrams.Evidence and limits
incottDecodeIdentityis unchanged.00in both positions (09 8f 01 02 00 f1 00 00 00cable,09 8f 01 02 02 f0 f1 00 02dongle; reports in test(incott): verify model code 0x02 on an original G23 Pro #261), consistent with the vendor reading no colour for other models.Changes
docs/incott-testing.md: a "Shell colour: Zero 29 only" subsection under model identification, and a pointer to it from the bytes 7-8 item in "Unresolved unknowns".Related: #261, #267.
Note
Document Zero 29 shell colour byte in incott testing notes
Adds documentation to incott-testing.md on the vendor's model-specific shell colour check for the Zero 29, including wireless and wired byte offsets and the pink-shell value. Notes that this behaviour is unverified on a Zero 29 and not implemented in
incottDecodeIdentity. Also records white G23 Pro example replies.Macroscope summarized 4401637.