Housekeeping: Format all tracked JS, TS and Markdown files with prettier - #5165
Merged
Merged
Conversation
Prettier only runs over staged files at commit time, so files it had not seen stayed unformatted. Formatting only, no behaviour change.
Security Review ✅
|
lmac-1
force-pushed
the
format-with-prettier
branch
from
September 10, 2026 16:33
9984b8b to
5841ceb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5165 +/- ##
=======================================
- Coverage 90.9% 90.9% -0.0%
=======================================
Files 425 425
Lines 21153 21153
=======================================
- Hits 19228 19222 -6
- Misses 1925 1931 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
My proposal (from Slack):
Question: can we also get the CI to run prettier automatically if it's not been run? Or is this expensive |
elias-ba
approved these changes
Sep 10, 2026
elias-ba
left a comment
Contributor
There was a problem hiding this comment.
Rafet na
PS: this means it's beautiful / beautiful in Wolof
midigofrank
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed unexpected formatting changes in a recent PR:
ChatInput.tsxandtypes/ai-assistant.tswere reformatted with no logic change. I couldn't drop them, because prettier runs when I commit and puts them straight back.I asked Claude to run prettier across every tracked file it covers, so hopefully this can unite things in future PRs:
That's the same prettier invocation as the pre-commit hook in
config/dev.exs:176-180, over every tracked file rather than just the staged ones.Validation steps
n/a: Formatting only, no behaviour change: line wrapping, union-type indentation, and trailing whitespace in a benchmarking sample.
Additional notes for the reviewer
I don't know how this drifted, and I'd rather we agree the process than guess.
.js .ts .tsx .jsx .md. Adding json/css/yml would touch 21 more files, and some of those shouldn't be reformatted (test/fixtures/*.json, the generatedpriv/static/manifest.json, andpriv/static/workflow-api.yaml, which prettier can't parse).AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)