Remove support for string-encoded dataclips in step:complete - #5104
Draft
josephjclark wants to merge 6 commits into
Draft
josephjclark wants to merge 6 commits into
josephjclark wants to merge 6 commits into
Conversation
Security Review ✅
|
elias-ba
marked this pull request as draft
August 28, 2026 11:58
midigofrank
force-pushed
the
support-binary-worker-dataclips
branch
2 times, most recently
from
August 28, 2026 14:02
01dd09c to
afe55e8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Description
In #5098 we added functionality to support dataclips being sent as JSON (where as previously they were sent as a JSON encoded string)
This PR removes the "maybe" and forces step:complete to treat the dataclip as an object.
We cannot merge this until we've had a major bump of the worker and found some resolution to #5103
Validation steps
1.Run a workflow
{ value }wrapper){ value }wrapperAI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy