Skip to content

Remove support for string-encoded dataclips in step:complete - #5104

Draft
josephjclark wants to merge 6 commits into
mainfrom
remove-maybe-decode-dataclip
Draft

josephjclark wants to merge 6 commits into
mainfrom
remove-maybe-decode-dataclip

Conversation

@josephjclark

@josephjclark josephjclark commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

DO NOT MERGE

Description

In #5098 we added functionality to support dataclips being sent as JSON (where as previously they were sent as a JSON encoded string)

This PR removes the "maybe" and forces step:complete to treat the dataclip as an object.

We cannot merge this until we've had a major bump of the worker and found some resolution to #5103

Validation steps

1.Run a workflow

  1. Ensure that the output of each step is correct (not an object with { value } wrapper)
  2. Ensure that scalar (number, string, boolean) return value are all handled with { value } wrapper

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

@github-project-automation github-project-automation Bot moved this to New Issues in Core Aug 28, 2026
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): step:complete still writes the dataclip with project_id derived authoritatively from the worker socket (lib/lightning_web/channels/run_channel.ex:207-210); the wire-format change to output_dataclip (lib/lightning/runs/handlers.ex:422,554-557) does not alter scoping.
  • S1 (authorization): N/A — no new controllers, LiveView events, channel handlers, or policy modules; only the shape of an existing worker payload field changed.
  • S2 (audit trail): N/A — the only affected writes are :step_result dataclip inserts (runtime execution data), not project/instance configuration, so no audit entry is expected.

@elias-ba
elias-ba marked this pull request as draft August 28, 2026 11:58
@midigofrank
midigofrank force-pushed the support-binary-worker-dataclips branch 2 times, most recently from 01dd09c to afe55e8 Compare August 28, 2026 14:02
Base automatically changed from support-binary-worker-dataclips to main August 28, 2026 15:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

1 participant