Conversation
|
@doc-han the action warns of a deprecated node version - can we get that fixed before merging? |
| jobs: | ||
| contract: | ||
| name: test build against lightning | ||
| if: contains(github.event.pull_request.labels.*.name, 'run_contract_tests') |
There was a problem hiding this comment.
So the tests only run on PRs with the label right now
Worried about that - if users forget to add the label, the tests will never run. In practice that means they'll never run.
I'd rather have tests run on all Ready PRs with a reviewer, so that hopefully we always run integration tests just before merging
Same idea on lightning too
There was a problem hiding this comment.
resolved. label dependency removed
| runs-on: ubuntu-latest | ||
| timeout-minutes: 45 | ||
| services: | ||
| postgres: |
There was a problem hiding this comment.
can we not default all this stuff? Does it really need to be declared in the action?
| @@ -0,0 +1,22 @@ | |||
| name: Integration Testing | |||
There was a problem hiding this comment.
I'd like to update the filename here too so that it maps to the actual action name. Otherwise it's hard to find
3 participants
Short Description
A one or two-sentence description of what this PR does.
Fixes #
Implementation Details
A more detailed breakdown of the changes, including motivations (if not provided in the issue).
QA Notes
List any considerations/cases/advice for testing/QA here.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.