Repository navigation
Conversation
…into 101526referenceissues
…Also adds documentation.
DreamListAbstract -> DreamList
Kapu1178
marked this pull request as ready for review
October 19, 2026 22:49
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on #2729
This is a big one. This PR removes IDreamList, and restructures the DreamList objects to better recycle behavior, reduce wasteful allocations, and introduce optimization routes.
Structural Changes
Method Changes
ToDantomList(), most of the time you're working with varying list types you will return aDantomListanyway.EnumerateLoosePairs()(needs new name, probably), a function for enumerating key-value pairs. If the given Key has no Value, it is set toDreamValue.Null.EnumerateTightPairs()(needs new name too), a function also for enumerating key-value pairs. However, this one outright excludes keys with no associated value.GetLoosePairs()andGetLooseKeys()as helpers for the above.GetKeys()toCopyKeys(), as that's what it does.TryGetElementByKey()TryGetElementByIndex()