Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Fixes
synk user listreporting a successful response as an API error.The Synkronus
GET /api/usershandler returned a valid JSON array but did not setContent-Type: application/json. The generated CLI client only parses the HTTP 200 response intoJSON200when the response content type is JSON, so the successful response was left unparsed and treated as an API error.This PR updates the server handler to return the correct JSON content type and adds regression coverage for both the server response and the CLI client parsing path.
Closes #1021.
Type of Change
Component(s) Changed
Testing
Checklist