Skip to content

refactor(formulus): remove legacy observation id mapping - #1015

Open
Grace256c wants to merge 9 commits into
OpenDataEnsemble:devfrom
Grace256c:fix/formulus-remove-legacy-id-mapping
Open

Grace256c wants to merge 9 commits into
OpenDataEnsemble:devfrom
Grace256c:fix/formulus-remove-legacy-id-mapping

Conversation

@Grace256c

@Grace256c Grace256c commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What & Why

Removes the legacy Formulus support for observations where the WatermelonDB row ID could differ from observation_id.

The current Formulus implementation keeps the WatermelonDB row ID and observation_id aligned for both locally created and server-pulled observations. This PR removes the remaining compatibility fallbacks so observation reads, mutations, sync operations, and mapping use that stable identity consistently.

I also reviewed the repository history before making the change. The ID-alignment fix landed before the first stable v1.0.0 release, with the older behavior only potentially affecting pre-release builds.

Closes #546.

Type of Change

  • Bug fix
  • New feature / enhancement
  • Refactor / cleanup
  • Documentation
  • Chore / other

Component(s) Changed

  • formulus (React Native mobile app)
  • formulus-formplayer (form WebView UI)
  • synkronus (Go backend)
  • synkronus-cli (command-line client)
  • synkronus-portal (web admin UI)
  • desktop (Tauri app)
  • packages (tokens / components)
  • Documentation / DevOps / CI

Testing

  • Added/updated tests
  • Manually tested
  • Not applicable

Checklist

@Grace256c

Copy link
Copy Markdown
Contributor Author

Hi @najuna-brian I’ve opened PR #1015 for issue #546 and completed the cleanup of the legacy observation ID-mapping support.

I also ran the Formulus pre-flight checks and the full test suite successfully. When you have a chance, could you please review the PR and let me know if there’s anything you’d like me to adjust?

Thank you.

@najuna-brian

Copy link
Copy Markdown
Member

Hi @Grace256c
Will please have a look!

@najuna-brian
najuna-brian self-requested a review October 23, 2026 09:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[formulus] Remove legacy id-mapping support

2 participants