Repository navigation
Conversation
Contributor
Author
|
Hi @najuna-brian I’ve opened PR #1015 for issue #546 and completed the cleanup of the legacy observation ID-mapping support. I also ran the Formulus pre-flight checks and the full test suite successfully. When you have a chance, could you please review the PR and let me know if there’s anything you’d like me to adjust? Thank you. |
Member
|
Hi @Grace256c |
najuna-brian
self-requested a review
October 23, 2026 09:13
najuna-brian
approved these changes
Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Removes the legacy Formulus support for observations where the WatermelonDB row ID could differ from
observation_id.The current Formulus implementation keeps the WatermelonDB row ID and
observation_idaligned for both locally created and server-pulled observations. This PR removes the remaining compatibility fallbacks so observation reads, mutations, sync operations, and mapping use that stable identity consistently.I also reviewed the repository history before making the change. The ID-alignment fix landed before the first stable
v1.0.0release, with the older behavior only potentially affecting pre-release builds.Closes #546.
Type of Change
Component(s) Changed
Testing
Checklist