The js-yaml override floor moves to the advisory it now answers (GHSA-2883-xcg3-v3hh) - #27
Merged
Merged
Conversation
GHSA-2883-xcg3-v3hh (HIGH, CVSS 7.5) patches at js-yaml 4.3.2; the TS lane resolved 4.3.1. The override cannot be removed, and that is worth stating rather than rediscovering: js-yaml is not a dependency of this lane at all. It is pulled by @hey-api/json-schema-ref-parser@1.4.4, which declares it at an EXACT "4.2.0" — so with no override the tree resolves 4.2.0, still inside the vulnerable range (>= 4.0.0, < 4.3.2). No range solver routes around an exact pin. The override is load-bearing and stays. Its range was already `^4.3.1`, which admits 4.3.2, so the lockfile alone was stale. Raising the floor to `^4.3.2` states which advisory the number answers instead of leaving it one patch below the line it exists to clear. Dependabot did not and will not author this: there is no dependency edge to bump, and this repo carries no .github/dependabot.yml — it has never opened a PR here. Verified in the TS lane: npm ci, npm audit --audit-level=low (0 vulnerabilities), typecheck, build, test, check:version, and check:drift — the last being the meaningful one, since it regenerates the client through the openapi-ts path that actually parses YAML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the TS lane's
js-yamloverride floor from^4.3.1to^4.3.2and relocks, clearingGHSA-2883-xcg3-v3hh (HIGH, CVSS 7.5 —
maxTotalMergeKeysdoes not limit CPU use for empty mergesources). Three lines of lockfile, one line of manifest.
The override cannot be removed, and that is the part worth recording.
js-yamlis not adependency of this lane at all — it is pulled transitively by
@hey-api/json-schema-ref-parser@1.4.4,which declares it at an exact
"4.2.0". With no override the tree resolves 4.2.0, which is insidethe vulnerable range (
>= 4.0.0, < 4.3.2), so removing it would reintroduce the advisory and droptwo patch lines besides. No range solver routes around an exact pin. The override is load-bearing and
stays.
The range was already
^4.3.1, which admits 4.3.2 — so the lockfile alone was stale and a relock wasstrictly sufficient. The floor moves anyway so the number states which advisory it answers, rather
than sitting one patch below the line it exists to clear. That is how the upstream node repo writes
its two overrides (
deepmerge-ts ^8.0.1against patch line 8.0.0,mysql2 ^3.23.1against 3.23.1).Why
Dependabot was never going to fix this. The alert is raised — repo-level security updates are
enabled — but there is no dependency edge to bump, so no fix is authorable, and this repository
carries no
.github/dependabot.yml: Dependabot has never opened a PR here at all. The alert wouldhave sat until someone looked.
Two follow-ups this turned up, deliberately not bundled into a security fix:
.github/dependabot.yml.opendpp-interophas one; this repo does not, so nothing sweepsthe three lanes on a schedule. Worth adding, per-lane (
typescript/,java/,python/).code-scanning/default-setupreads{"state":"not-configured"}and thealerts endpoint 404s with "no analysis found". This is the published client surface and has never
been CodeQL-scanned;
opendpp-interophas been, and its findings there were real (sixjs/polynomial-redosHIGH, since fixed at source).Verification
npm ciexit 0 ·npm audit --audit-level=low0 vulnerabilities (was 1 HIGH) ·typecheck·build·test·check:version· andcheck:drift— the meaningful one, since it regenerates theclient through the
openapi-tspath that actually parses YAML, so 4.3.2 is exercised rather thanmerely installed.
allowScriptsneeded no change: no install-script-bearing package moved version.