Skip to content

fix: tolerate punctuation in voice activation finish phrase - #1219

Draft
HKLHaoBin wants to merge 8 commits into
Open-Less:betafrom
HKLHaoBin:feat/issue-1003-voice-activation
Draft

HKLHaoBin wants to merge 8 commits into
Open-Less:betafrom
HKLHaoBin:feat/issue-1003-voice-activation

Conversation

@HKLHaoBin

Copy link
Copy Markdown
Collaborator

Summary

  • Fix voice activation finish commands when local ASR inserts punctuation inside the phrase, such as 完成,语音录入。.
  • Apply the same NFKC-aware punctuation handling to transcript cleanup so the finish phrase is removed without dropping punctuation from the spoken body.
  • Add regression coverage for Chinese punctuation, full-width punctuation, whitespace, and suffix-only matching.

Closes #1003

Verification

  • Review Bugbot first round found one full-width punctuation cleanup edge case.
  • Fixed the finding and re-ran Review Bugbot: No bugs found.
  • cargo test -p openless-core: passed.
  • cargo test -p openless-core voice_activation: passed.
  • cargo fmt --all -- --check: passed.
  • git diff --check: passed.

Actions

All workflows passed for commit 37e4665d:

Windows artifact openless-windows-x64 was downloaded and SHA-256 verified:

d7cde8d236657ce5aaae02ae7e3fe6216d0f8bb4a12b5c6553f8c51642bb5331

Issue test instructions: #1003 (comment)

🤖 Generated with Claude Code

HKLHaoBin and others added 8 commits September 16, 2026 16:53
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-activation

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts:
#	.github/workflows/android-apk.yml
#	openless-all/app/package-lock.json
#	openless-all/app/package.json
#	openless-all/app/src-tauri/Cargo.lock
#	openless-all/app/src-tauri/Cargo.toml
#	openless-all/app/src-tauri/tauri.conf.json
…t/issue-1003-voice-activation

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts:
#	openless-all/app/crates/openless-core/src/cloud_sync_e2ee_documents/registry.rs
#	openless-all/app/src-tauri/src/core_adapters.rs
#	openless-all/app/src-tauri/src/recorder.rs
#	openless-all/app/src/components/SettingsModal.tsx
#	openless-all/app/src/i18n/zh-CN.ts
#	openless-all/app/src/lib/ipc/mock-data.ts
#	openless-all/app/src/lib/types.ts
#	openless-all/app/src/pages/settings/RecordingInputSection.tsx
#	openless-all/app/src/pages/settings/tabs.tsx
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@HKLHaoBin
HKLHaoBin marked this pull request as draft October 17, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

功能建议:用语音替代按键来激活输入法

1 participant