Repository navigation
test(ui): await complete native wheel scrolling before rest assertion - #1203
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修正 WebKit 原生滚动测试的提前终态判断（不改 App）
最终 main CI
38795512971的 WebKit 样本把 120ms 内暂时未更新的 11px 当作“滚动已停”，160ms 后原生滚动正常到 450px，导致假失败。失败 trace / error-context 已保留。改为等待本次 wheel 的完整、按容器上限夹取的目标位移，再保留原来的停止后位置不变断言；不推进动画时钟、不放宽数值容差、不取消任何断言，也不改应用的滚动/动画实现。比原先“只需有正位移 + 一段相等样本”更严格。
本地 Chromium/WebKit 各 5 次，共 10/10 通过。此 PR 的 CI 仍须全绿后合并。当前正式版生产候选未改；既有 main 已通过的原生平台不因这条测试重复执行。