Repository navigation
fix(bindings): get ci green on macos 15 and remove the slow call flake - #671
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's CI is red and #670 cannot go green, and macos-14 is retired on November 2. This carries #670's commit plus the fixes for both, so merging it also lands #670.
Main (
Python Wheel (windows-x86_64), run 41192023539): a timing flake.test_a_slow_call_leaves_the_loop_ticking_and_other_calls_waitingassumed a 1 s stall outlasted its setup; on a slow runnerbwaited only 0.25 s. The stall is now a gate the test releases, so every step runs inside it. Without the call lock the rewritten test fails.#670 (
Python Wheel (macos-arm64)on macos-15): two separate causes, measured with a probe on both images.gethostbyaddr("127.0.0.1")IPVersion.AllIPVersion.V4Onlyhttp_front/test_demo.pytests:HTTPServer.server_bindcallsgetfqdn, so the demo provider sat in reverse DNS past every test timeout. It now skips the lookup, whose result it never read.test_a_host_advertised_over_dns_sd_is_found_and_proved: the test now skips when a zeroconf-only probe cannot see its own advertisement. The probe does not touchPeerStreamManager, so a fault in the manager still fails the test.Not proved: discovery uses
IPVersion.Allinpeer_stream_manager.pyanddnssd_bridge.py. It works on macOS 26 hardware, but the cause on the runner was not isolated, so a real macOS 15 machine is unverified, and DNS-SD discovery has no CI coverage on that image.Update from the green run (682c673): the macOS wheel job reported 1148 passed and 4 skipped, the same 4 as before, so the DNS-SD test ran and passed on macos-15 this time and the skip did not fire. The zeroconf failure therefore varies between runs of that image rather than holding on every one; the table above is one probe, and the skip exists for the runs where it recurs.