Fix paging issue on older versions of octopus - #261
Merged
Merged
Conversation
Older versions of Octopus (3.17.14 for example) don't have the property NumberOfPages. This fix falls back to the Page.Next approach which is present in the older versions.
There was a problem hiding this comment.
🟡 Changes recommended
The critical pagination issue must be fixed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates usage-count pagination to support older Octopus versions without NumberOfPages.
Changes:
- Adds cross-version pagination detection.
- Applies fallback pagination to count functions.
- Updates pagination logging.
File summaries
| File | Summary |
|---|---|
REST/PowerShell/Administration/GetUsageCounts.ps1 |
Adds compatibility pagination logic. Critical issue: an empty Page.Next link may be treated as present, causing repeated empty-page requests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rohitnb
self-requested a review
September 16, 2026 15:34
rohitnb
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of Octopus (3.17.14 for example) don't have the property NumberOfPages. This fix falls back to the Page.Next approach which is present in the older versions.