fix(updates): reuse Android APK after installer dismissal - #401
fix(updates): reuse Android APK after installer dismissal#401veryCrunchy wants to merge 6 commits into
Conversation
Obiente previewNC Native · Obiente updates this comment as the preview changes. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6779f096cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Outcome
Retain the verified APK after Android opens the system installer. If the user dismisses confirmation, the update card can reopen it without downloading the package again.
Before reuse, the cached APK goes through the same checksum, package identity, version, SDK, and signer verification as a new download. Invalid cached packages are discarded. Coroutine cancellation is preserved, and installer failures retain the current structured, privacy-preserving diagnostics.
The retry action and APK-specific wording appear only for direct-release Android updates. Desktop installer behavior is unchanged. The UI change is integrated into the current
AppUpdateSettingscomponent.Follow-up to #176.
Validation
On the dedicated Linux build host at source head
5b703db23b4520290915c5b8c9f8d34579adfa21, treef6cfb3e9:AndroidProjectContentClientTest: 14 tests passed.ProjectNewsAndUpdatesTest: 5 tests passed.:androidApp:assembleDebugpassed.bash tools/check-repository.shandgit diff --checkpassed.The branch includes
mainat92dd2ae9cec1dc7dac16907e66d7b870694ebbbf. Hosted checks and regenerated marketing captures are separate merge gates.Evidence limits
This revision has deterministic test and build coverage. It does not include a device or emulator run that dismisses and reopens Android's system installer, or a signed release upgrade test.