Repository navigation
feat(feedback): thumbs up/down on answers (MCP + chat) with an answer_log table - #1162
Draft
northdpole wants to merge 9 commits into
Draft
northdpole wants to merge 9 commits into
northdpole wants to merge 9 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
northdpole
force-pushed
the
feat/answer-feedback
branch
2 times, most recently
from
October 20, 2026 08:51
b40939d to
957841c
Compare
northdpole
force-pushed
the
feat/ingest-comprehension
branch
from
October 20, 2026 09:21
c306180 to
6b2c573
Compare
northdpole
force-pushed
the
feat/answer-feedback
branch
14 times, most recently
from
October 21, 2026 20:05
76307f2 to
dc9eb78
Compare
northdpole
force-pushed
the
feat/ingest-comprehension
branch
from
October 21, 2026 21:09
b6ded96 to
0a34ae0
Compare
northdpole
force-pushed
the
feat/answer-feedback
branch
from
October 21, 2026 21:09
dc9eb78 to
c672c15
Compare
Adds answer_log (every answer + optional rating) with a migration that also merges the two open alembic heads, and answer_feedback helpers (log, rate, list). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…up/down Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…feedback, GET /admin/feedback Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ER_LOG_CHAT) The public chat page promises not to store questions, so only MCP answers are logged by default. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…answers are logged Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…stored Replaces the storage notice added earlier: when thumbs are shown the deployment stores answers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Fold into the feedback commits during the cleanup pass. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
northdpole
force-pushed
the
feat/ingest-comprehension
branch
from
October 21, 2026 23:09
0a34ae0 to
a6573ed
Compare
northdpole
force-pushed
the
feat/answer-feedback
branch
from
October 21, 2026 23:09
c672c15 to
2556722
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds thumbs up/down on answers so staging can collect labelled data.
answer_logtable (+ migrationd1e2f3a4b5c6, which joins the two existing heads) and recording of ratings.askreturns ananswer_id; newrate_answertool.answer_id;POST /rest/v1/answer_feedback;GET /admin/feedback. Chat answers are logged only when a deployment opts in (ANSWER_LOG_CHAT=1).alembic_single_head_testfails when the migration chain has more than one head.Stacked on #1158 (order: #1142, #1155, #1159, #1158, this). Needs the migration run and
ANSWER_LOG_CHAT=1set on staging.asknow writes one row per question, so this should be deployed after measurement runs.Tested:
answer_feedback_test,alembic_single_head_test,mcp_ask_testpass; Black clean. Frontend tests run in CI.🤖 Generated with Claude Code