Conversation
Applies the jakarta / Tomcat 10 / Turbine 7 / Restlet 2.6 / Spring 6 migration on top of the GitHub monorepo/CI structure (branched off origin/develop = 9493aba, still javax at vXnat 1.10.1-SNAPSHOT, artifact "batch-launch"), rather than the old Bitbucket gh/main (0.9.0) lineage. The monorepo commit didn't touch src, so the migrated source applied cleanly. Source (4 files): Turbine 7 RunData -> PipelineData in the action/screens; org.apache.commons.lang.StringUtils -> org.apache.commons.lang3. build.gradle (kept gh/develop's monorepo shape — xnatPluginJar, CI publishing, gitManifestAttrs): vXnat -> 1.11.0-SNAPSHOT; scoped mavenLocal; Java toolchain(21) + compile fork=true (Lombok 1.18.34 on JDK 21); `configurations.all { exclude }` -> `configureEach` (Gradle 9 forbids post-resolution exclude mutation); XNAT- provided deps -> compileOnly; turbine:turbine -> org.apache.turbine:turbine and velocity -> velocity-engine-core; springfox (dead on Spring 6) -> io.swagger:swagger-annotations; javax.servlet -> jakarta.servlet; commons-lang 2.6 -> commons-lang3; container-service 3.2.0:fat -> 3.9.0-SNAPSHOT:fat. Verified: clean xnatPluginJar builds batch-launch-0.9.0-SNAPSHOT-xpl.jar. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the batch-launch plugin to the Jakarta EE / Tomcat 10.1 stack introduced by XNAT 1.11, building against
1.11.0-SNAPSHOT.5 files changed, 59 insertions(+), 44 deletions(-)— java:4 gradle:1Work unit affected
batch-launch plugin
Jira ticket
N/A — part of the XNAT 1.11 Jakarta / Tomcat 10 cutover.
How this maps to the core cutover review guide
Bucketed with the same script the core review guide publishes in its Appendix A (
-w; import-only vs ≤8-line trivial vs substantial), refined so comment-only non-import changes count as mechanical. Run againstorigin/develop:4
.javafiles. Percentages are of each column's own total, so the shape is comparable to the 649-file core cutover.Mechanical rules — which of core's §3 rules apply here
javax.servlet->jakarta.servletorg.restlet.*1.1 -> 2.6RunData->PipelineDataRules scoring zero here are absent from this plugin, not skipped.
Judgment calls, against core's §4
RunData->PipelineData(6 lines) -- the silent-failure rule. The rest is the build file and three trivial files.Test results
Plugin jar builds clean from this branch (run 2026-09-14):
./gradlew xnatPluginJar->batch-launch-0.9.0-SNAPSHOT-xpl.jar.No test suite was run for this plugin — it has no meaningful unit-test surface exercised here, and the integration verification for the whole set was done by deploying to the Docker 1.11 stack rather than per-repo. Treat the build as the evidence this PR carries.
Notes for review
Targets
develop. The branch was cut fromdevelopand is level with it (0 behind).Depends on XNAT
1.11.0-SNAPSHOT, which is unreleased but now published. Either source works:Resolve from JFrog (no local build needed). A
1.11.0-SNAPSHOTbuild was published tolibs-snapshot-localon 2026-09-10 (1.11.0-20260910.185426-1), including theorg.nrg:parentBOM and thexnat-data-builderGradle plugin. If this plugin'sbuild.gradlealready listshttps://nrgxnat.jfrog.io/nrgxnat/libs-snapshot, it resolves as-is.Or build core locally, if you are also changing core or need a cutover commit newer than the published snapshot:
mavenLocal()is listed first in most plugin builds, so a stale local publish silently wins over JFrog under an identical version string.rm -rf ~/.m2/repository/org/nrgwhen switching to the JFrog route.Opened as a draft with no reviewer requested — reviewers to be added when it is marked ready.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KxtKswYPXUQ9zVRDaZcCB4