Repository navigation
[Sessions] Fix the test process crash after a workshared model opens - #138
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The external injector patch depends on native behavior that remains unverified for the original workshared-model crash on Revit 2025/.NET 8.
No open issues 🎉
What changed in this PR
Updates the Revit Injector dependencies to address test-process crashes caused by native file-writing threads after a RevitApiTest opens a workshared model.
Changes:
- Upgrades Injector packages for Revit 2021–2026 to
*.1.11and Revit 2027 to2027.0.11. - Documents the crash fix under release
2027.0.9.
| File | Description |
|---|---|
Directory.Packages.props |
Updates Injector dependencies across all supported Revit years. |
CHANGELOG.md |
Records the workshared-model crash fix and links issue #136. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
A
RevitApiTestrun continues after Revit ends a native thread that writes a file, such as the worksharing log writer of a workshared model.Description:
What changed
*.1.11and2027.0.11patch versions.The
2027.0.11release filters the console writes of Revit during initialization without managed code.A native thread of Revit that writes a file never enters the runtime.
CHANGELOG.mdlists the fix under2027.0.9.How verified
Release.R21,Release.R23, andRelease.R27, zero warnings, zero errors.Release.R23: full suite, 149 passed, 3 skipped, zero failed.Release.R27: full suite, 125 passed, 3 skipped, zero failed.2027.0.11release ends a native thread insideWriteFilewithTerminateThreadand runs garbage collections.The test fails on
2027.0.10and passes on2027.0.11, on Revit 2023 and Revit 2027.2027.0.11, the benchmarks of dotTrace fails on a RevitApiBenchmark and leaves the benchmark process running RevitBenchmark#64 record their dotTrace snapshots without a crash.Quality Checklist