Skip to content

[Sessions] Fix the test process crash after a workshared model opens - #138

Merged
Nice3point merged 1 commit into
developfrom
sessions/136-terminated-writer-thread-crash
Nov 1, 2026
Merged

Nice3point merged 1 commit into
developfrom
sessions/136-terminated-writer-thread-crash

Conversation

@Nice3point

@Nice3point Nice3point commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

Summary of the Pull Request

What is this about:

A RevitApiTest run continues after Revit ends a native thread that writes a file, such as the worksharing log writer of a workshared model.

Description:

What changed

  • The Revit dependencies move to the *.1.11 and 2027.0.11 patch versions.
    The 2027.0.11 release filters the console writes of Revit during initialization without managed code.
    A native thread of Revit that writes a file never enters the runtime.
  • CHANGELOG.md lists the fix under 2027.0.9.

How verified

  • Build: Release.R21, Release.R23, and Release.R27, zero warnings, zero errors.
  • Tests, Release.R23: full suite, 149 passed, 3 skipped, zero failed.
  • Tests, Release.R27: full suite, 125 passed, 3 skipped, zero failed.
  • A test of the 2027.0.11 release ends a native thread inside WriteFile with TerminateThread and runs garbage collections.
    The test fails on 2027.0.10 and passes on 2027.0.11, on Revit 2023 and Revit 2027.
  • With 2027.0.11, the benchmarks of dotTrace fails on a RevitApiBenchmark and leaves the benchmark process running RevitBenchmark#64 record their dotTrace snapshots without a crash.
  • Not covered: a workshared model in this test project.

Quality Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Nice3point
Nice3point marked this pull request as ready for review November 1, 2026 15:47
Copilot AI balanced review requested due to automatic review settings November 1, 2026 15:47
@Nice3point
Nice3point merged commit eb849be into develop Nov 1, 2026
1 check passed
@Nice3point
Nice3point deleted the sessions/136-terminated-writer-thread-crash branch November 1, 2026 15:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The external injector patch depends on native behavior that remains unverified for the original workshared-model crash on Revit 2025/.NET 8.

No open issues 🎉

What changed in this PR

Updates the Revit Injector dependencies to address test-process crashes caused by native file-writing threads after a RevitApiTest opens a workshared model.

Changes:

  • Upgrades Injector packages for Revit 2021–2026 to *.1.11 and Revit 2027 to 2027.0.11.
  • Documents the crash fix under release 2027.0.9.
File Description
Directory.Packages.props Updates Injector dependencies across all supported Revit years.
CHANGELOG.md Records the workshared-model crash fix and links issue #136.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants