Repository navigation
[Element][Parameter] Align the element lookups with First and FirstOrDefault - #122
Merged
Merged
Conversation
…r an element of another type
Nice3point
marked this pull request as ready for review
October 29, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Element lookups follow LINQ
FirstandFirstOrDefault:ToElementandAsElementreturn the element or throw, and theirOrDefaultcounterparts return the element ornull.Description:
What changed
ToElement,ToElement<T>InvalidOperationExceptionInvalidCastExceptionAsElement,AsElement<T>InvalidOperationExceptionInvalidCastExceptionToElementOrDefault,ToElementOrDefault<T>nullnullAsElementOrDefault,AsElementOrDefault<T>nullnullToElementOrDefault,ToElementOrDefault<T>,AsElementOrDefault, andAsElementOrDefault<T>are new.ToElement,ToElement<T>,AsElement, andAsElement<T>return non-nullable types.Breaking changeswith the migration to theOrDefaultcounterpart.Where to look
InvalidOperationException, the exceptioncollector.First()throws for an empty collector.ArgumentExceptionwas the alternative, with the id as the invalid argument.AsElementthrows for a parameter that holds no element, such as an empty material parameter or a category id. Code that reads an optional parameter moves toAsElementOrDefault.How verified
Release.R19,R21,R23,R24,R25, andR27, zero errors.ElementIdExtensionsTests92 passed,ParameterExtensionsTests30 passed, none skipped.Open questions
2027.0.6section of the changelog. A minor version is the alternative.ToElements<T>andToOrderedElements<T>keep their behavior: a collection that mixes types throwsInvalidCastException.Quality Checklist