Readyup - Fixup and refactor checks (Stack PR 2 of 2) - #2047
Open
nullsystem wants to merge 2 commits into
Open
Conversation
Make sure it only triggers readyup for gamemodes that deals with readyup, if not, just go on as if readyup not a thing.
nullsystem
changed the title
nullsystem
changed the title
AdamTadeusz
previously approved these changes
Aug 11, 2026
Collaborator
Author
|
@AdamTadeusz Fixed readyup shown for non-playing players: 43086fc |
nullsystem
added
the
New Changes for Reviewers
Contributor
|
usually we check if a player is on a playing team by comparing against FIRST_PLAYING_TEAM |
AdamTadeusz
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make sure it only triggers readyup for gamemodes that deals with
readyup, if not, just go on as if readyup not a thing.
Toolchain
Linked Issues
Stack created with GitHub Stacks CLI • Give Feedback 💬