Update notifications.py - #651
Closed
ryankrage77 wants to merge 1 commit into
Closed
ryankrage77 wants to merge 1 commit into
ryankrage77 wants to merge 1 commit into
Conversation
re-create apobj to avoid Matrix transaction IDs being re-used, which causes silent message duplicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Matrix notifications only send successfully once when birdnet_analysis service starts, then all subsequent notifications fail.
apobj currently persists for the lifetime of birdnet_analysis, causing the Matrix transaction ID to be re-used across messages, and subsequent messages to to be silently duplicated.
This minimal fix re-creates apobj per notification, so it generates a new transaction ID each time. In my testing, this fixes the issue and notifications work as expected again.