Add pprof endpoint flag to the operator - #2805
Conversation
c08b48f to
ccca1af
Compare
Add a --pprof-bind-address flag wired to controller-runtime's built-in pprof server (ctrl.Options.PprofBindAddress), for profiling the operator's memory and CPU at large node counts. The endpoint is disabled by default and only serves when an address (e.g. ":6060") is given. Expose the address as the operator.pprof.bindAddress chart value, passed to the operator only when set. Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
ccca1af to
41c6c1a
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe operator adds a Merge Risk: 🔵 Low · up to The PR adds an optional pprof endpoint that is disabled by default, but enabling it on a broad address such as :6060 could expose profiling data to unintended clients. The change is mergeable with owner awareness that access protection or a localhost-only binding must be confirmed. Comment |
Description
Add a
--pprof-bind-addressflag wired to controller-runtime's built-inpprof server (
ctrl.Options.PprofBindAddress), for profiling theoperator's memory and CPU at large node counts. The endpoint is disabled
by default and only serves when an address (e.g.
":6060") is given.The address is exposed as the
operator.pprof.bindAddresschart value,passed to the operator only when set.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
go build ./cmd/gpu-operator;helm templatewith and withoutoperator.pprof.bindAddressset (flag rendered only when set);helm lint.