Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/helm/openshell/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: {{ include "openshell.fullname" . }}-node-reader
name: {{ include "openshell.fullname" . }}-node-reader-{{ .Release.Namespace }}
labels:
{{- include "openshell.labels" . | nindent 4 }}
rules:
Expand Down
4 changes: 2 additions & 2 deletions deploy/helm/openshell/templates/clusterrolebinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "openshell.fullname" . }}-node-reader
name: {{ include "openshell.fullname" . }}-node-reader-{{ .Release.Namespace }}
labels:
{{- include "openshell.labels" . | nindent 4 }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: {{ include "openshell.fullname" . }}-node-reader
name: {{ include "openshell.fullname" . }}-node-reader-{{ .Release.Namespace }}
subjects:
- kind: ServiceAccount
name: {{ include "openshell.serviceAccountName" . }}
Expand Down
6 changes: 6 additions & 0 deletions deploy/helm/openshell/tests/clusterrole_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ release:
namespace: my-namespace

tests:
- it: includes the release namespace in the ClusterRole name
asserts:
- equal:
path: metadata.name
value: openshell-node-reader-my-namespace

- it: grants managed namespace NetworkPolicy apply permissions
set:
server.drivers.kubernetes.workspaceMode: managed
Expand Down
31 changes: 31 additions & 0 deletions deploy/helm/openshell/tests/clusterrolebinding_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

suite: ClusterRoleBinding RBAC
templates:
- templates/clusterrolebinding.yaml
release:
name: openshell
namespace: my-namespace

tests:
- it: includes the release namespace in the ClusterRoleBinding name
asserts:
- equal:
path: metadata.name
value: openshell-node-reader-my-namespace

- it: references the namespace-scoped ClusterRole in roleRef
asserts:
- equal:
path: roleRef.name
value: openshell-node-reader-my-namespace

- it: binds the service account in the release namespace
asserts:
- contains:
path: subjects
content:
kind: ServiceAccount
name: openshell
namespace: my-namespace
Loading