ci(security): add informational security checks #2930
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "problemMatcher": [ | ||
| { | ||
| "owner": "actionlint", | ||
| "pattern": [ | ||
| { | ||
| "regexp": "^(?:\\x1b\\[\\d+m)?(.+?)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*:(?:\\x1b\\[\\d+m)*(\\d+)(?:\\x1b\\[\\d+m)*: (?:\\x1b\\[\\d+m)*(.+?)(?:\\x1b\\[\\d+m)* \\[(.+?)\\]$", | ||
| "file": 1, | ||
| "line": 2, | ||
| "column": 3, | ||
| "message": 4, | ||
| "code": 5 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| { | ||
| "$schema": "https://json.schemastore.org/sarif-2.1.0.json", | ||
| "version": "2.1.0", | ||
| "runs": [ | ||
| { | ||
| "tool": { | ||
| "driver": { | ||
| "name": "Actionlint", | ||
| "version": {{ getVersion | json }}, | ||
| "informationUri": "https://github.com/rhysd/actionlint", | ||
| "rules": [ | ||
| {{$first := true}} | ||
| {{range $ := allKinds}} | ||
| {{if $first}}{{$first = false}}{{else}},{{end}} | ||
| { | ||
| "id": {{json $.Name}}, | ||
| "name": {{$.Name | toPascalCase | json}}, | ||
| "defaultConfiguration": { | ||
| "level": "warning" | ||
| }, | ||
| "fullDescription": { | ||
| "text": {{json $.Description}} | ||
| }, | ||
| "helpUri": "https://github.com/rhysd/actionlint/blob/v1.7.12/docs/checks.md" | ||
| } | ||
| {{end}} | ||
| ] | ||
| } | ||
| }, | ||
| "results": [ | ||
| {{$first := true}} | ||
| {{range $ := .}} | ||
| {{if $first}}{{$first = false}}{{else}},{{end}} | ||
| { | ||
| "ruleId": {{json $.Kind}}, | ||
| "level": "warning", | ||
| "message": { | ||
| "text": {{json $.Message}} | ||
| }, | ||
| "locations": [ | ||
| { | ||
| "physicalLocation": { | ||
| "artifactLocation": { | ||
| "uri": {{json $.Filepath}}, | ||
| "uriBaseId": "%SRCROOT%" | ||
| }, | ||
| "region": { | ||
| "startLine": {{$.Line}}, | ||
| "startColumn": {{$.Column}}, | ||
| "endColumn": {{$.EndColumn}}, | ||
| "snippet": { | ||
| "text": {{json $.Snippet}} | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| {{end}} | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| self-hosted-runner: | ||
| labels: | ||
| - linux-amd64-cpu8 | ||
| - linux-amd64-gpu-rtxpro6000-latest-1 | ||
| - linux-arm64-cpu8 | ||
| - linux-arm64-gpu-l4-latest-1 | ||
| - nv | ||
| - ubuntu-26.04 | ||
| - windows-arm64 | ||
| - wsl-amd64-gpu-rtxpro6000-latest-1 | ||
|
|
||
| paths: | ||
| .github/workflows/windows-msvc.yml: | ||
| ignore: | ||
| - 'constant expression "false" in condition' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: OpenShell Rust and SDKs | ||
|
|
||
| paths: | ||
| - crates | ||
| - examples | ||
| - sdk/go | ||
| - sdk/typescript/src | ||
| - python/openshell | ||
|
|
||
| paths-ignore: | ||
| - python/openshell/_proto | ||
| - sdk/typescript/src/gen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| name: CodeQL | ||
|
|
||
| on: | ||
| pull_request: | ||
| merge_group: | ||
| types: [checks_requested] | ||
| push: | ||
| branches: [main] | ||
| schedule: | ||
| - cron: "29 5 * * 6" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: CodeQL (${{ matrix.language }}) | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 90 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - language: rust | ||
| build-mode: none | ||
| - language: go | ||
| build-mode: manual | ||
| - language: python | ||
| build-mode: none | ||
| - language: javascript-typescript | ||
| build-mode: none | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up Go | ||
| if: matrix.language == 'go' | ||
| uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 | ||
| with: | ||
| go-version-file: sdk/go/go.mod | ||
| cache-dependency-path: sdk/go/go.sum | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| build-mode: ${{ matrix.build-mode }} | ||
| config-file: ./.github/codeql/codeql-config.yml | ||
|
|
||
| - name: Build Go SDK | ||
| if: matrix.language == 'go' | ||
| working-directory: sdk/go | ||
| run: go build ./... | ||
|
|
||
| - name: Analyze | ||
| id: analyze | ||
| uses: github/codeql-action/analyze@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7 | ||
| with: | ||
| category: /language:${{ matrix.language }} | ||
| output: codeql-results | ||
| upload: never | ||
|
|
||
| - name: Summarize findings | ||
| if: always() | ||
| env: | ||
| LANGUAGE: ${{ matrix.language }} | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| shopt -s globstar nullglob | ||
| sarif_files=(codeql-results/**/*.sarif) | ||
|
|
||
| { | ||
| echo "### CodeQL: $LANGUAGE" | ||
| echo | ||
| if [ "${#sarif_files[@]}" -eq 0 ]; then | ||
| echo "No SARIF report was produced." | ||
| else | ||
| finding_count=$(jq -s '[.[].runs[]?.results[]?] | length' "${sarif_files[@]}") | ||
| echo "Findings: $finding_count" | ||
| echo | ||
| echo "Findings are informational and do not fail CI." | ||
| fi | ||
| } >> "$GITHUB_STEP_SUMMARY" | ||
|
|
||
| - name: Upload SARIF to Code Scanning | ||
| if: >- | ||
| steps.analyze.outcome == 'success' && | ||
| (github.event_name != 'pull_request' || | ||
| github.event.pull_request.head.repo.full_name == github.repository) | ||
|
Collaborator
There was a problem hiding this comment. [P2] Dependabot PRs are treated like fork PRs for |
||
| uses: github/codeql-action/upload-sarif@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7 | ||
| with: | ||
| sarif_file: codeql-results | ||
| category: /language:${{ matrix.language }} | ||
|
|
||
| - name: Upload SARIF | ||
| if: always() | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: codeql-${{ matrix.language }}-${{ github.run_id }} | ||
| path: codeql-results | ||
| if-no-files-found: ignore | ||
| retention-days: 14 | ||
|
|
||
| result: | ||
| name: OpenShell / CodeQL (informational) | ||
| if: always() | ||
| needs: analyze | ||
| runs-on: ubuntu-latest | ||
| permissions: {} | ||
| steps: | ||
| - name: Evaluate analyzer execution | ||
| env: | ||
| ANALYZE_RESULT: ${{ needs.analyze.result }} | ||
| shell: bash | ||
| run: | | ||
| if [ "$ANALYZE_RESULT" != "success" ]; then | ||
| echo "::error::One or more CodeQL analyzers did not complete successfully." | ||
| exit 1 | ||
| fi | ||
| echo "All CodeQL analyzers completed; findings remain informational." | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it expands what dependabot will scan, which is fine, but does it need to be part of this PR? It didn't seem to be called out directly but seems unrelated to the security checks. If it's not required here it would be nice to see it as its own PR to highlight that we're expanding dependabot's duties.