Skip to content

fix: preserve exact recluster metadata columns - #96

Merged
phoman14 merged 6 commits into
DEVfrom
DEV-fix-recluster-metadata-columns
Oct 16, 2026
Merged

phoman14 merged 6 commits into
DEVfrom
DEV-fix-recluster-metadata-columns

Conversation

@phoman14

@phoman14 phoman14 commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Preserve requested reclusterSeuratObject() metadata fields under their exact names; do not rename metadata columns globally.
  • Report every requested metadata field that is absent from the object.
  • Validate PCA and cluster-resolution inputs before reclustering.
  • Add fixture-backed coverage for dotted, underscored, and mixed-punctuation metadata names, missing fields, empty selections, custom prefixes, and invalid parameters.

Issues

No related open issue was found. Closed issue #93 concerns plotMetadata() blank selections and is unrelated.

PR Checklist

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.). No exported API changes.
  • Update NEWS.md with a short description of any user-facing changes and reference the PR number.
  • Run devtools::check() locally and fix all notes, warnings, and errors. devtools::check() was run but is blocked by pre-existing undeclared ggalluvial and patchwork dependencies in DESCRIPTION.

@phoman14
phoman14 merged commit 97f20e2 into DEV Oct 16, 2026
6 of 12 checks passed
@phoman14
phoman14 deleted the DEV-fix-recluster-metadata-columns branch October 16, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant