Skip to content

fix: clarify Recluster old column validation - #104

Merged
phoman14 merged 7 commits into
DEVfrom
DEV-fix-recluster-empty-old-columns
Oct 16, 2026
Merged

phoman14 merged 7 commits into
DEVfrom
DEV-fix-recluster-empty-old-columns

Conversation

@phoman14

@phoman14 phoman14 commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Changes

  • Detect existing Seurat clustering-resolution metadata from stored graphs and assay-derived NN/SNN naming patterns.
  • Rename selected prior clustering columns before reclustering; remove only unselected columns that Reclustering replaces.
  • Distinguish missing metadata from retained non-clustering metadata, with concise mixed-selection logging.
  • Use Seurat default graph naming during reclustering and correct the UMAP/t-SNE reduction argument.

Issues

No linked issue.

PR Checklist

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.).
  • Update NEWS.md with a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.html
  • Run devtools::check() locally and fix all notes, warnings, and - [ ] Run devtools::check() locally and fix all notes, warnings, and - [ ] Run devtools::check() locally and fin the namespace but absent from Imports/Depends.

@phoman14
phoman14 merged commit aef13d8 into DEV Oct 16, 2026
7 of 12 checks passed
@phoman14
phoman14 deleted the DEV-fix-recluster-empty-old-columns branch October 16, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant