Skip to content

Add dynamic resolution of var INSTALLED_REGIONALIZATION_RESULTS - #6

Open
mxkpp wants to merge 1 commit into
developmentfrom
maxkipp-portability
Open

mxkpp wants to merge 1 commit into
developmentfrom
maxkipp-portability

Conversation

@mxkpp

@mxkpp mxkpp commented Sep 10, 2026

Copy link
Copy Markdown

Add dynamic resolution of var INSTALLED_REGIONALIZATION_RESULTS, in response to the removal of the hard-coded Python version string in: NGWPC/nwm-rte#40.

This should not be merged until the above RTE PR is merged.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@mxkpp

mxkpp commented Sep 10, 2026

Copy link
Copy Markdown
Author

@zhengtaocui the other PR on nwm-rte has been merged, FYI. That is a breaking change for nextgen-support-scripts until this PR is also merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant