Repository navigation
feat(observe): isolate passive desktop control read progress - #111
Merged
Merged
Conversation
rldyourmnd
marked this pull request as ready for review
October 6, 2026 06:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A completed desktop heartbeat RTT cannot show whether a reply stalled before its length prefix, inside the body, during an I/O poll, or alongside late runtime scheduling. Periodic snapshots can also miss a burst of late replies.
Add passive framed-read progress with a separate weak observer. The existing wake-driven reader is never polled, canceled or restarted by the observer; this avoids masking a potential missed wake. The observer reads only local scalar progress and exact outstanding-probe metadata, using coherent single-writer atomic progress, probe try-lock and skipped ticks with bounded log frequency. It does not query transport state, own a stream/connection, or change wire, timeouts, retries, input replay or liveness. Logs contain byte lengths/counts and timing, without payloads/addresses.
A matched newer probe excludes older missing echoes from diagnostic freshness while preserving ordinary late correlation. Tests cover actual fragmented prefix/body read continuity, a never-waking reader remaining unpolled despite observation, owner cleanup, and diagnostic freshness without correlation changes.
Final Mac strict workspace/desktop/owned-backend Clippy and110 unit tests, Linux strict Clippy and123 unit tests (two unchanged platform ignores), optimized Mac agent and full exact-head public CI pass; this is an observability increment, not a claim that the remaining latency root cause or product acceptance is complete.