feat: trait-based placement and provider-account tenancy - #203
Merged
Merged
Conversation
Tenancy is the provider account: one personal user account plus organizations by exact provider login, never purpose groupings. Device materialization gains `match` (owner_login, names, name_prefixes, visibility) evaluated against repository facts with first-match-wins ordering, so placement no longer requires a portfolio label and several trait rules may share one workspace root. Policy matching gains `name_prefixes` for cross-owner families such as `server-*`. `selector` membership placement and portfolio policy matching stay valid for compatibility; GDS_WORKSPACE_PLACEMENT_AMBIGUOUS is retired in favour of deterministic ordering. ADR 0040 records the decision. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servers,forks,*-projects) stop being a tenancy axismaterialization.include[].matchplaces repositories by provider facts (owner_login,names,name_prefixes,visibility); includes evaluate in declaration order, first match wins — several trait rules may share one workspace rootpolicy.match.name_prefixeslets cross-owner policies (e.g. everyserver-*repository) match without inventing a portfolioselectormembership placement andmatch.portfoliosremain valid for compatibility;GDS_WORKSPACE_PLACEMENT_AMBIGUOUSretired in favour of deterministic orderingschema_version: 1preserved — all changes are additive or relaxations.Test plan
scripts/validate_shell.sh— PASS (8 scripts)scripts/validate_go_core.sh --quick— PASSgo test ./...— all packages passpython3 -m pytest— 70 passed, 9 subtests (uv env; system python lacks pytest)go build -trimpath ./core/cmd/gds— OKGenerated with Devin