Skip to content

fix(ci): treat an up-to-date dependabot branch as update success - #149

Merged
rldyourmnd merged 1 commit into
mainfrom
fix/convergence-update-branch-guard
Oct 4, 2026
Merged

rldyourmnd merged 1 commit into
mainfrom
fix/convergence-update-branch-guard

Conversation

@rldyourmnd

Copy link
Copy Markdown
Contributor

Summary

The convergence job for dependabot bumps died on #145: update-branch answered 422 no new commits on the base branch — the branch was already current — but the guard only accepted the literal already up to date string, so it exited 1 before the catalog sync ran. Catalog stayed at setup-uv v10.1.0 while workflows carried v10.2.0, failing tool-registry and catalog core validators.

The fix normalizes both up-to-date replies to the existing success marker, so the poll resolves immediately instead of timing out on an update that never ran.

Permissions diff

None — same pull-requests: write call, same error surface, only the accept-set widened to the API's second success phrasing.

Threat-model note

The step still writes only to the one open pull request bound to workflow_run.head_branch after verifying head.sha matches the triggering run; widening the accept-string cannot grant pushes elsewhere.

Test plan

  • Failed message observed live on run 36387529520: 422 no new commits on the base branch
  • Next dependabot bump on an already-current branch converges the catalog instead of dying

Generated with Devin

update-branch answers 422 'no new commits on the base branch' when the
bound pull request is already current. That string matched neither the
'already up to date' success pattern nor a real failure, so the step
exited 1 and the convergence job never ran the catalog sync -- leaving
setup-uv v10.2.0 workflows with a v10.1.0 catalog on #145.

Signed-off-by: rldyourmnd <danil@nddev.it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant