Bug fixes for issue 128 - #129
Merged
Merged
Conversation
added 5 commits
July 1, 2026 15:50
sadielbartholomew
approved these changes
Sep 14, 2026
| ) | ||
|
|
||
|
|
||
| logger = logging.getLogger(__name__) |
Member
There was a problem hiding this comment.
There is a long-standing issue on adding in proper logging - see #41, and generally would be better to add it in wholescale in one PR than have the odd log here and there. So I will either remove this logging for now, else escalate adding in the rest of the logging once this PR is merged and I have coordinated on release prep.
Comment on lines
+67
to
+73
| f = _FakeField( | ||
| { | ||
| "X": _FakeConstruct(np.linspace(0, 350, 36)), | ||
| "Y": _FakeConstruct(np.linspace(-90, 90, 19)), | ||
| "T": _FakeConstruct([1], dtvalues=["2001-01-01 00:00:00"]), | ||
| } | ||
| ) |
Member
There was a problem hiding this comment.
We generally use the set of cf.example_fields() to test, which contain comprehensive metadata and together cover numerous forms of data one might want to encode via the CF Conventions. So it is much preferred to use these when wanting quick-access 'dummy' fields. I'll update the testing accordingly post-merge.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic issue is that with larger grids, cartopy doesn't do the transforming in the right order. This fixes some of those issues. There are some tests as well. However, the image comparisons don't fully match with previous tests, though eyeballing suggests these are not significant.