Skip to content

Add missing required property on example - #195

Open
marian2js wants to merge 1 commit into
MrBlenny:masterfrom
marian2js:patch-1
Open

marian2js wants to merge 1 commit into
MrBlenny:masterfrom
marian2js:patch-1

Conversation

@marian2js

Copy link
Copy Markdown

The example on the README was failing with Typescript because scale was not set.

Error:(79, 25) TS2322: Type '{ offset: { x: number; y: number; }; nodes: { node1: { id: string; type: string; position: { x: number; y: number; }; ports: { port1: { id: string; type: string; properties: { value: string; }; }; port2: { id: string; type: string; properties: { ...; }; }; }; }; node2: { ...; }; }; links: { ...; }; selected: {}; hov...' is not assignable to type 'IChart<undefined, undefined, undefined, undefined>'.
  Property 'scale' is missing in type '{ offset: { x: number; y: number; }; nodes: { node1: { id: string; type: string; position: { x: number; y: number; }; ports: { port1: { id: string; type: string; properties: { value: string; }; }; port2: { id: string; type: string; properties: { ...; }; }; }; }; node2: { ...; }; }; links: { ...; }; selected: {}; hov...' but required in type '{ offset: IPosition; nodes: { [id: string]: INode<undefined, undefined>; }; links: { [id: string]: ILink<undefined>; }; scale: number; selected: ISelectedOrHovered; hovered: ISelectedOrHovered; }'.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant