Conversation
xuyaqist
requested review from
Dallas98,
Jasonxia007,
WMC001,
YehongPan,
hhhhsc701 and
jeffwu-1999
as code owners
September 30, 2026 03:20
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation consistently satisfies the stated selection and recommendation behavior with focused regression coverage and an idempotent migration.
Review effort: Balanced
Findings: None
What changed in this PR
Updates AIDP search selection and recommendation behavior while migrating existing metadata.
Changes:
- Keeps independent AIDP search selectable in all deployment modes.
- Recommends deployment-appropriate knowledge tools.
- Adds regression tests and an idempotent metadata migration.
| File | Description |
|---|---|
backend/services/tool_configuration_service.py |
Removes deployment-based hiding of independent AIDP search. |
backend/services/nl2agent_service.py |
Recommends independent AIDP search in both modes. |
sdk/nexent/core/tools/ind_aidp_search_tool.py |
Marks the tool user-selectable. |
deploy/sql/migrations/v2.7.1_001_ind_aidp_search_selectable.sql |
Corrects persisted selection metadata. |
test/backend/services/test_tool_configuration_service.py |
Tests selection metadata behavior. |
test/backend/services/test_nl2agent_service.py |
Tests mode-dependent recommendations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knowledge_base_searchunavailable for manual selection andind_aidp_searchselectable regardless of AIDP deployment mode.aidp_searchwhen AIDP knowledge is enabled,knowledge_base_searchwhen disabled, andind_aidp_searchin both modes.Verification
backend/.venv/Scripts/python.exe -m pytest test/backend/services/test_tool_configuration_service.py -k 'independent_aidp_search' -q(2 passed)backend/.venv/Scripts/python.exe -m pytest test/backend/services/test_nl2agent_service.py -k 'installed_resource_catalog_filters_knowledge_tools_by_deployment' -q(2 passed)git diff --check(passed)The SQL migration has not been applied to a live database.