Release 5.1.0-beta01 - #763
Merged
Merged
Conversation
Apply the catalog version to Rx2 before configuring publication. Reject mismatched generated POM and module metadata versions in builds and before publishing. Update beta release notes and instructions. Signed-off-by: Matt Ramotar <matt.ramotar@icloud.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
=======================================
Coverage 83.53% 83.53%
=======================================
Files 42 42
Lines 899 899
Branches 170 170
=======================================
Hits 751 751
Misses 91 91
Partials 57 57 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares
5.1.0-beta01and fixes Rx2 publication versioning. The alpha12 publish job failed because it tried to upload the already-existingrx2@unspecifiedcoordinate. The Android convention now applies the shared catalog version before publishing is configured, so Rx2 and its Store dependency both use5.1.0-beta01.Generated POMs and Gradle module metadata are checked against the catalog, including internal dependencies and target redirects. These checks run during ordinary builds and again on macOS before Maven Central publication. The changelog covers the MutableStore fixes from #762, and the release instructions match the current automated workflow.
Validation:
version=unspecifiedbefore the fix.Commands:
Merging this PR triggers Maven Central publication through the existing CI workflow. Swift/XCFramework publication remains a separate manual workflow.
Note
Medium Risk
Changes affect Maven Central publication and CI gates; incorrect versioning could block releases, but runtime library behavior in this diff is limited to release/docs/tooling.
Overview
Prepares 5.1.0-beta01 (catalog version, changelog, updated RELEASING.md) and hardens release publishing so Rx2 and other Android artifacts no longer ship as
unspecified.The Android convention plugin now sets
project.versionfrom the sharedstorecatalog entry before Maven publish is configured, aligning Rx2 with KMP modules. A newverifyPublicationVersionsGradle check validates generated POMs and Gradle module metadata against that catalog—internalorg.mobilenativefoundation.storedependencies, variant constraints, andavailable-atredirect URLs—with unit tests and hook-up tocheckplusconfigureMavenPublishing.CI runs tooling plugin tests/ktlint ahead of the main build and runs
verifyPublicationVersionson the macOS publish job before Maven Central upload.Reviewed by Cursor Bugbot for commit a4b17cd. Bugbot is set up for automated code reviews on this repo. Configure here.