Skip to content

DEVOPS-1131: Removing the need for a manual release tag - #167

Open
RomFloreani wants to merge 1 commit into
developfrom
DEVOPS-1131
Open

DEVOPS-1131: Removing the need for a manual release tag#167
RomFloreani wants to merge 1 commit into
developfrom
DEVOPS-1131

Conversation

@RomFloreani

@RomFloreani RomFloreani commented Aug 11, 2026

Copy link
Copy Markdown

DEVOPS-1131 - python_deploy_prod workflow to use tag from revision: no manual input

Summary

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

Copilot AI lite review requested due to automatic review settings August 11, 2026 13:32
@github-actions github-actions Bot changed the title Removing the need for a manual release tag DEVOPS-1131: Removing the need for a manual release tag Aug 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the production Python deployment workflow to remove the requirement for manually entering a release tag on workflow_dispatch, by defaulting to the ref tag that triggered the run and adding a guardrail to fail fast when no tag can be determined.

Changes:

  • Made release-tag optional for manual runs and defaulted the deploy tag to github.ref_name when appropriate.
  • Added a validate-release-tag job to ensure the workflow has a resolvable tag before attempting publication.
  • Wired both Conda and PyPI reusable-workflow calls to depend on the validation step.
Suppressed comments (4)

.github/workflows/python_deploy_prod.yml:45

  • publish-conda is a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the - can be parsed as an operator).
    needs: validate-release-tag
    if: ${{ github.event_name == 'release' || github.event.inputs.publish-conda == 'true' }}

.github/workflows/python_deploy_prod.yml:51

  • release-tag is a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the - can be parsed as an operator).
      release-tag: ${{ github.event.release.tag_name || github.event.inputs.release-tag || github.ref_name }}

.github/workflows/python_deploy_prod.yml:58

  • publish-pypi is a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the - can be parsed as an operator).
    needs: validate-release-tag
    if: ${{ github.event_name == 'release' || github.event.inputs.publish-pypi == 'true' }}

.github/workflows/python_deploy_prod.yml:65

  • release-tag is a hyphenated workflow_dispatch input, so it should be referenced with bracket notation in expressions (otherwise the - can be parsed as an operator).
      release-tag: ${{ github.event.release.tag_name || github.event.inputs.release-tag || github.ref_name }}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +34 to +38
- name: Ensure a release tag is resolvable
run: |
if [ "${{ github.event_name }}" = "workflow_dispatch" ] && \
[ -z "${{ github.event.inputs.release-tag }}" ] && \
[ "${{ github.ref_type }}" != "tag" ]; then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants